Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding basic metrics support for recommendation service (Python) #416

Merged
merged 3 commits into from
Oct 10, 2022
Merged

Adding basic metrics support for recommendation service (Python) #416

merged 3 commits into from
Oct 10, 2022

Conversation

mviitane
Copy link
Member

@mviitane mviitane commented Oct 8, 2022 •
edited
Loading

Changes

  • First part of metrics support, manual metrics creation for recommendation service (Python)
  • Bump versions for opentelemetry api, sdk, exporter, and instrumentation libraries (to enable metrics).

Fixes #72

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes

@mviitane mviitane requested a review from a team October 8, 2022 13:52
@mviitane
Adding basic metrics support for recommendation service (Python)
813df95 
- First part of metrics support, manual metrics creation for recommendation service (Python)
- Bump versions for opentelemetry api, sdk, exporter, and instrumentation libraries (to enable metrics).
@mviitane mviitane force-pushed the manual_metrics_recommendationservice branch from 284981f to 813df95 Compare October 8, 2022 14:41
julianocosta89
julianocosta89 approved these changes Oct 8, 2022
View reviewed changes
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Tested locally and metrics are there 🥳
recommendation_metric

@mviitane mviitane force-pushed the manual_metrics_recommendationservice branch from 04f67d9 to 2eb986a Compare October 10, 2022 17:36
@cartersocha cartersocha merged commit 88c0440 into open-telemetry:main Oct 10, 2022
@mviitane mviitane deleted the manual_metrics_recommendationservice branch October 11, 2022 06:13
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
@mviitane
Adding basic metrics support for recommendation service (Python) (ope…
ef600c8 
…n-telemetry#416)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fatsheep9146 fatsheep9146 fatsheep9146 left review comments

@reyang reyang reyang left review comments

@mic-max mic-max mic-max approved these changes

@julianocosta89 julianocosta89 julianocosta89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review and enhance metric support for recommendation service (Python)
6 participants
@mviitane @fatsheep9146 @mic-max @julianocosta89 @reyang @cartersocha